[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:258
     return CGOpts.DataSections && !CGOpts.DisableIntegratedAS;
+  case Triple::GOFF:
+    llvm::report_fatal_error("ASan not implemented for GOFF.");
----------------
Minor nit: GOFF appears after XCOFF in most of the "unsorted" lists.


================
Comment at: llvm/include/llvm/Support/TargetRegistry.h:518
+    case Triple::GOFF:
+      report_fatal_error("GOFF MCObjectStreamer not implemented yet."); 
     }
----------------
The coding guidelines have been updated to clarify the formatting of `report_fatal_error` messages:
https://llvm.org/docs/CodingStandards.html#id14


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4731
     return ".llvmbc";
+  case Triple::GOFF:
+    llvm_unreachable("GOFF is not yet implemented");
----------------
Minor nit: GOFF appears after XCOFF in most of the "unsorted" lists.


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4749
     return ".llvmcmd";
+  case Triple::GOFF:
+    llvm_unreachable("GOFF is not yet implemented");
----------------
Minor nit: GOFF appears after XCOFF in most of the "unsorted" lists.


================
Comment at: llvm/lib/Support/Triple.cpp:657
   case Triple::XCOFF: return "xcoff";
+  case Triple::GOFF:  return "goff";
   }
----------------
Minor nit: Maintain alphabetical order for lists that are already sorted.


================
Comment at: llvm/lib/Support/Triple.cpp:726
+  case Triple::systemz:
+    if (T.getOS() == Triple::ZOS)
+      return Triple::GOFF;
----------------
Is it beneficial to express the check this way instead of with `isOSzOS`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82081/new/

https://reviews.llvm.org/D82081