[PATCH] D82072: [InstCombine] Combile select & Phi by same condition
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 18 05:57:21 PDT 2020
spatel added subscribers: aqjune, nlopes.
spatel added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:2555
// FIXME: Remove this workaround when freeze related patches are done.
// For select with undef operand which feeds into an equality comparison,
// don't simplify it so loop unswitch can know the equality comparison
----------------
xbolva00 wrote:
> @spatel can you look at this fixme?
That was added with D35811.
I don't know exact status, but I think there are still several steps to go before we can start adding freeze instructions to IR early in the optimization pipeline and not cause perf regressions.
cc @aqjune @nlopes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82072/new/
https://reviews.llvm.org/D82072
More information about the llvm-commits
mailing list