[PATCH] D82049: Fix crash in VectorCombine when attempting to peephole ConstantVector sequences

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D82049#2100020 <https://reviews.llvm.org/D82049#2100020>, @clin1 wrote:

> Updated to run InstCombine before the vector transformations. The insert-binop-with-constant test needed a few changes. InstructionSimplify checks for constant divisors with 0/undef elements and undef's the entire result.


We are not running the entire InstCombine here - that could be expensive. This is more like running InstSimplify. The changes to the other tests are good; they show that VectorCombine is not losing the ideal optimizations on those patterns.

I think this patch is almost ready, but please adjust the test and upload with full context ("-U9999"):
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface



================
Comment at: llvm/test/Transforms/VectorCombine/X86/fold-extract.ll:11
+; Function Attrs: norecurse nounwind uwtable
+define dso_local i32 @constant_fold_crash(<4 x i32> %x) local_unnamed_addr #0 {
+; CHECK-LABEL: @constant_fold_crash(
----------------
Please remove unnecessary text:
Function Attrs comment, dso_local, local_unnamed_addr, #0 (and corresponding attributes line).

I think you can just add this test to the existing extract-binop.ll test file instead of adding a new file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82049/new/

https://reviews.llvm.org/D82049