[PATCH] D82071: [IR] Convert profile metadata in createCallMatchingInvoke()

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 04:52:08 PDT 2020


yrouban added a comment.

In D82071#2100391 <https://reviews.llvm.org/D82071#2100391>, @hans wrote:

> Seems reasonable, but I don't know that much about profile info.. is it actually useful to have "branch_weights" metadata on a call? Isn't it enough that there's profile info on the branch towards the BB that has the call instruction? Or is this data used for something more?


Branch_weights are useful for call instructions as said in the LLVM LangRef (https://llvm.org/docs/BranchWeightMetadata.html).
Let us wait for @xur to comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82071/new/

https://reviews.llvm.org/D82071





More information about the llvm-commits mailing list