[PATCH] D82073: [ObjectYAML][ELF] Add support for emitting the .debug_info section.

Thu Jun 18 04:19:05 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:456
+
+## g) Test that all the properties can be overridden by the section header when
+## the "debug_info" entry exists.
----------------
Higuoxing wrote:
> jhenderson wrote:
> > Higuoxing wrote:
> > > In order not to bring too much difficulty. The common tests are very similar to the tests in other DWARF sections, except this one. The property of the `.debug_abbrev` section is overridden as well in this test.
> > I'm not sure I follow. What's the point of overriding .debug_abbrev too? It will at least need explaining in a comment.
> I want to test that `yaml2obj` is still able to overwrite the section header fields of the `.debug_abbrev` section when the `.debug_info` section exists. Does it make sense here?
Is there actually any interaction in the code between the .debug_abbrev and .debug_info header writing? If not, I don't think you need to test the combination.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82073/new/

https://reviews.llvm.org/D82073