[PATCH] D82010: [llvm-readobj] - Add a validation of the GNU hash table to printGnuHashHistogram().
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 18 03:46:38 PDT 2020
grimar added inline comments.
================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnuhash.test:130
# SYMNDX-NEXT: Buckets: [2]
-# SYMNDX-NEXT: warning: '[[FILE]]': the first hashed symbol index (2) is larger than the number of dynamic symbols (2)
+# SYMNDX-NEXT: warning: '[[FILE]]': unable to dump 'Values' for the SHT_GNU_HASH section: the first hashed symbol index (2) is larger than the number of dynamic symbols (2)
# SYMNDX-NEXT: }
----------------
jhenderson wrote:
> Hmm... This message is clearly not quite right even before your change: 2 is obviously not larger than 2...
>
> Anyway, that's a separate issue.
I'll fix, thanks for spotting.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82010/new/
https://reviews.llvm.org/D82010
More information about the llvm-commits
mailing list