[PATCH] D81988: [ELF] Fix a dyn_cast<Defined>(nullptr) crash if a local symbol appears in InputFile::symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

I think this is okay. LGTM, with nit.



================
Comment at: lld/test/ELF/invalid/broken-symtab-duplicate-symbol.test:2
+# REQUIRES: x86
+## The ELF spec says all symbols with STB_LOCAL binding precede the weak and #
+## global symbols. Out-of-order local symbols are represented by null entries in
----------------
Nit: spurious '#' at end of line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81988/new/

https://reviews.llvm.org/D81988