[PATCH] D81971: [AVR] Disassemble multiplication instructions

[Dylan McKay via Phabricator via llvm-commits]

dylanmckay requested changes to this revision.
dylanmckay added a comment.
This revision now requires changes to proceed.

Couple of nitpicks, otherwise good to go.



================
Comment at: llvm/lib/Target/AVR/Disassembler/AVRDisassembler.cpp:173
+  unsigned r = fieldFromInstruction(Insn, 0, 3) + 16;
+  if (DecodeGPR8RegisterClass(Inst, d, Address, Decoder) == MCDisassembler::Fail) { return MCDisassembler::Fail; }
+  if (DecodeGPR8RegisterClass(Inst, r, Address, Decoder) == MCDisassembler::Fail) { return MCDisassembler::Fail; }
----------------
Fit to 80 characters, prefer `return` on a new line


================
Comment at: llvm/lib/Target/AVR/Disassembler/AVRDisassembler.cpp:182
+  unsigned rr = fieldFromInstruction(Insn, 0, 4) + 16;
+  if (DecodeGPR8RegisterClass(Inst, rd, Address, Decoder) == MCDisassembler::Fail) { return MCDisassembler::Fail; }
+  if (DecodeGPR8RegisterClass(Inst, rr, Address, Decoder) == MCDisassembler::Fail) { return MCDisassembler::Fail; }
----------------
Same here re. 80 chars


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81971/new/

https://reviews.llvm.org/D81971