[PATCH] D81968: [AVR] Decode single register instructions

Dylan McKay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 23:11:36 PDT 2020


dylanmckay requested changes to this revision.
dylanmckay added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/AVR/Disassembler/AVRDisassembler.cpp:159
+  unsigned d = fieldFromInstruction(Insn, 4, 5);
+  if (DecodeGPR8RegisterClass(Inst, d, Address, Decoder) == MCDisassembler::Fail) { return MCDisassembler::Fail; }
+  return MCDisassembler::Success;
----------------
Fit to 80 columns ([ref](https://llvm.org/docs/CodingStandards.html#source-code-width))

My own OCD: prefer `return` on a new line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81968/new/

https://reviews.llvm.org/D81968





More information about the llvm-commits mailing list