[PATCH] D81995: [xray] Option to omit the function index

[Ian Levesque via Phabricator via llvm-commits]

ianlevesque marked 3 inline comments as done.
ianlevesque added inline comments.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:114
+///< Set with -fno-xray-function-index to omit the index section.
+CODEGENOPT(XRayOmitFunctionIndex , 1, 0)
+
----------------
MaskRay wrote:
> Nit: a variable name with a positive meaning may be easier to understand.
I had the entire patch that way at first, making the index something you would enable (defaulting to true) but it was much worse.


================
Comment at: clang/test/Driver/XRay/xray-function-index-flags.cpp:20
+//
+// REQUIRES: x86_64 || x86_64h
----------------
MaskRay wrote:
> I know some tests may be inconsistent but the prevailing style is to place `REQUIRES:` at the top.
I already committed this, but I can do a quick follow up for these nits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81995/new/

https://reviews.llvm.org/D81995