[PATCH] D81457: [LLD][PowerPC] Add support for R_PPC64_PCREL34

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Generally looks good, only a few nits.



================
Comment at: lld/ELF/Arch/PPC64.cpp:1009
+
+    uint64_t si0 = (val & si0Mask) << 16;
+    uint64_t si1 = (val & si1Mask);
----------------
si0 and si1 are only used once. Consider inlining them.


================
Comment at: lld/ELF/Arch/PPC64.cpp:1012
+    uint64_t instr = readPrefixedInstruction(loc) & ~fullMask;
+
+    writePrefixedInstruction(loc, instr | si0 | si1);
----------------
This empty line can be deleted


================
Comment at: lld/test/ELF/ppc64-reloc-pcrel34.s:17
+
+
+.text
----------------
One empty line is sufficient.


================
Comment at: lld/test/ELF/ppc64-reloc-pcrel34.s:18
+
+.text
+.section .text_low, "ax", %progbits
----------------
Delete `.text`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81457/new/

https://reviews.llvm.org/D81457