[PATCH] D55682: [ELF] Support for setting __start/__stop symbol visibility
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 17 14:35:09 PDT 2020
phosek added a comment.
In D55682#2094089 <https://reviews.llvm.org/D55682#2094089>, @MaskRay wrote:
> Please add a test, `startstop-visibility.s` (I would like start-stop-visibility.s, but some existing tests use the startstop- prefix).
>
> Use `-triple=x86_64` and use `llvm-readelf -s` to check visibility. Check both `__start_foo` and `__stop_foo`. Don't add another `__start_bar`.
>
> Please mention that GNU ld and gold from binutils 2.35 onwards will support the option (
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=cae64165f47b64898c4f1982d294862cfae89a47 )
Done, the implementation should now match its GNU counterpart.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55682/new/
https://reviews.llvm.org/D55682
More information about the llvm-commits
mailing list