[PATCH] D82051: [llvm-install-name-tool] Add -rpath option

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 2 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:853
+
+    // Cannot specify duplicate -rpath entries
+    auto It1 = std::find_if(
----------------
Unlike `-delete_rpath`, we thought it was necessary to check duplication in case of `-rpath`. This is because it would not be useful to do something like `-rpath A B .... -rpath A C` or something like `-rpath A B ... -rpath B C`. Additionally,  this also matches XCode's -rpath behavior.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:867
+
+    auto IsValidWith = [&OldRPath, &NewRPath ]<class Iterator>(
+                           Iterator First, Iterator Last, const char *ErrorMsg)
----------------
This highlights a warning :
`warning: lambda templates are only available with -std=c++2a or -std=gnu++2a [-Wpedantic]`

Is this fine? Not sure what I should do about it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82051/new/

https://reviews.llvm.org/D82051