[PATCH] D79625: [PowerPC] Extend .reloc directive on PowerPC

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFStreamer.cpp:147
+
+// Emit the .relc directive. This is a PPC extension of what is being done in
+// the generic ELF streamer.
----------------
nit: .relc -> .reloc



================
Comment at: llvm/test/MC/PowerPC/future-reloc-with-expr.s:2
+# RUN: llvm-mc -triple=powerpc64le-unknown-unknown -filetype=obj %s | \
+# RUN: llvm-objdump -dr --mcpu=future - | FileCheck %s
+
----------------
Should we use `--mcpu=power10` since that's available?
Maybe the name of this file should also be updated? `pcRel-reloc-with-expr.s`?


================
Comment at: llvm/test/MC/PowerPC/future-reloc-with-expr.s:2
+# RUN: llvm-mc -triple=powerpc64le-unknown-unknown -filetype=obj %s | \
+# RUN: llvm-objdump -dr --mcpu=future - | FileCheck %s
+
----------------
lei wrote:
> Should we use `--mcpu=power10` since that's available?
> Maybe the name of this file should also be updated? `pcRel-reloc-with-expr.s`?
do we need to add tests for BE?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79625/new/

https://reviews.llvm.org/D79625