[PATCH] D82005: [InstCombine] Replace selects with Phis

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Canonicalization between phis and select in either direction are pretty dangerous I think, I remember seeing discussions around this a couple times on llvm-dev, for example https://groups.google.com/d/msg/llvm-dev/VcJnLMI7Deg/20b3kBGMCgAJ.

We might want to look at some of the specific issues that D81375 <https://reviews.llvm.org/D81375> ran into. Here is one: https://llvm.godbolt.org/z/KN9GFh We should be replacing %s with %c, but nothing in the pipeline does that. This looks like something we should be addressing anyway, because I don't think this patch does.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82005/new/

https://reviews.llvm.org/D82005