[PATCH] D79064: [test-suite] Register result codes with lit.

[Julian Lettner via Phabricator via llvm-commits]

yln updated this revision to Diff 271445.
yln added a comment.

ResultCode has a self-registering constructor now, calling
`add_result_category()` is no longer necessary.  See `5c244115c98a`.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79064/new/

https://reviews.llvm.org/D79064

Files:
  litsupport-tests/hash/check/lit.out
  litsupport-tests/hash/tests/skip.test
  litsupport-tests/hash/tests/unchanged.test
  litsupport/test.py


Index: litsupport/test.py
===================================================================
--- litsupport/test.py
+++ litsupport/test.py
@@ -13,8 +13,8 @@
 import os
 
 
-SKIPPED = lit.Test.ResultCode('SKIPPED', False)
-NOEXE = lit.Test.ResultCode('NOEXE', True)
+NOCHANGE = lit.Test.ResultCode('NOCHANGE', 'Executable Unchanged', False)
+NOEXE = lit.Test.ResultCode('NOEXE', 'Executable Missing', True)
 
 
 class TestSuiteTest(lit.formats.ShTest):
@@ -46,7 +46,7 @@
             litsupport.modules.hash.compute(context)
             if litsupport.modules.hash.same_as_previous(context):
                 result = lit.Test.Result(
-                        SKIPPED, 'Executable identical to previous run')
+                        NOCHANGE, 'Executable identical to previous run')
                 val = lit.Test.toMetricValue(context.executable_hash)
                 result.addMetric('hash', val)
                 return result
Index: litsupport-tests/hash/tests/skip.test
===================================================================
--- /dev/null
+++ litsupport-tests/hash/tests/skip.test
@@ -1 +0,0 @@
-RUN: tests/foo.sh
Index: litsupport-tests/hash/check/lit.out
===================================================================
--- litsupport-tests/hash/check/lit.out
+++ litsupport-tests/hash/check/lit.out
@@ -1,3 +1,3 @@
-CHECK-DAG: SKIPPED: test-suite :: tests/skip.test
+CHECK-DAG: NOCHANGE: test-suite :: tests/unchanged.test
 CHECK-DAG: PASS: test-suite :: tests/normal.test
 CHECK: Expected Passes


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79064.271445.patch
Type: text/x-patch
Size: 1524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200617/c9f7ebd2/attachment-0001.bin>