[PATCH] D82037: [x86][lvi][seses] Use SESES at O0 for LVI mitigation

[Zola Bridges via Phabricator via llvm-commits]

zbrid created this revision.
zbrid added reviewers: craig.topper, sconstab.
Herald added subscribers: llvm-commits, jfb, hiraditya.
Herald added a project: LLVM.
zbrid retitled this revision from "[lvi][seses] Use SESES at O0 for LVI mitigation" to "[x86][lvi][seses] Use SESES at O0 for LVI mitigation".
zbrid added a parent revision: D80964: [X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass.
zbrid marked an inline comment as done.
zbrid added inline comments.
zbrid edited the summary of this revision.


================
Comment at: llvm/test/CodeGen/X86/lvi-hardening-loads.ll:37
+; X64-NOOPT-NEXT:      lfence
+; X64-NOOPT-NEXT:      lfence
 ; X64-NOOPT-NEXT:      movl $0, -{{[0-9]+}}(%rsp)
----------------
Sorry, this is totally weird and I'll look into why this happens. 


Use SESES as the fallback at O0 where the optimized LVI pass isn't desired due
to its effect on build times at O0.

I updated the LVI tests since this changes the code gen for the tests touched in the parent revision.

This is a follow up to the comments I made here: https://reviews.llvm.org/D80964

Hopefully we can continue the discussion here.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82037

Files:
  llvm/lib/Target/X86/X86.h
  llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp
  llvm/lib/Target/X86/X86SpeculativeExecutionSideEffectSuppression.cpp
  llvm/lib/Target/X86/X86TargetMachine.cpp
  llvm/test/CodeGen/X86/O0-pipeline.ll
  llvm/test/CodeGen/X86/lvi-hardening-loads.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82037.271433.patch
Type: text/x-patch
Size: 8909 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200617/092bc279/attachment.bin>