[PATCH] D81948: [LLD][PowerPC] Add support for R_PPC64_GOT_PCREL34

Wed Jun 17 11:18:56 PDT 2020

sfertile added inline comments.

================
Comment at: lld/ELF/Arch/PPC64.cpp:1019
+  case R_PPC64_GOT_PCREL34: {
+    uint64_t si0Mask = 0x00000003FFFF0000;
+    uint64_t si1Mask = 0x000000000000FFFF;
----------------
@MaskRay comments on the other patch about lowercase hex literals applies here as well. Ditto for the suggested test change (ie labels instead of sections)

================
Comment at: lld/test/ELF/ppc64-got-pcrel34-reloc.s:33
+# RELA:        0009a578  0000000200000014 R_PPC64_GLOB_DAT       0000000000000000 glob_int8 + 0
+.section .GLOB_INT_PCREL_OFFSET,"ax", at progbits
+	pld 3, glob_int8 at got@PCREL(0), 1
----------------
It this test just to show the linker doesn't modify the load instruction that follows the PC-relative load from the got?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81948/new/

https://reviews.llvm.org/D81948