[PATCH] D80964: [X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass

[Zola Bridges via Phabricator via llvm-commits]

zbrid added a comment.

In D80964#2097227 <https://reviews.llvm.org/D80964#2097227>, @craig.topper wrote:

> It may also be worth noting that this new unoptimized pass is equivalent to the behavior of the mitigation implemented for gcc through binutils. Given that I wonder if it makes sense to use this pass at O1 <https://reviews.llvm.org/owners/package/1/> or O2 <https://reviews.llvm.org/owners/package/2/> and save the mostly costly analysis for O3 <https://reviews.llvm.org/owners/package/3/>.


Ah that's an interesting point, but I'm not too sure similarity to gcc should be prioritized here. Is there a reason to value the similarities with the gcc approach? Up until now we've accepted the differences and I don't think we have new evidence suggesting the similarity should be prioritized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80964/new/

https://reviews.llvm.org/D80964