[PATCH] D81990: AMDGPU/GlobalISel: Remove selection of MAD/MAC when not available

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/udiv.i64.ll:4
+; RUN: llc -global-isel -amdgpu-codegenprepare-disable-idiv-expansion=0 -mtriple=amdgcn-amd-amdhsa -denormal-fp-math-f32=preserve-sign -mattr=+mad-mac-f32-insts < %s | FileCheck -check-prefixes=CHECK,CGP %s
+; RUN: llc -global-isel -amdgpu-codegenprepare-disable-idiv-expansion=0 -mtriple=amdgcn-amd-amdhsa -denormal-fp-math-f32=preserve-sign -mattr=-mad-mac-f32-insts < %s | FileCheck -check-prefixes=NOMAD %s
 
----------------
I think it's a bit much to have this giant extra test just for this. Can you just add a run line to legalize-fmad.* instead?


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/udiv.i64.ll:184
+;
+; NOMAD-LABEL: v_udiv_i64:
+; NOMAD:       ; %bb.0:
----------------
The check prefix being an actual word confused me. NOFMAD maybe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81990/new/

https://reviews.llvm.org/D81990