[PATCH] D81297: AMDGPU: Implement computeKnownAlignForTargetInstr

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 05:53:53 PDT 2020


arsenm added a comment.

In D81297#2097573 <https://reviews.llvm.org/D81297#2097573>, @foad wrote:

> Why not put it in generic code to start with? I don't understand why the concern about conflicting alignment would prevent that. I mean, are you more confident about how to handle conflicting alignments for AMDGPU than you are for all other targets?


I know in this case, even if the call site specified a lower alignment, you're always getting at least 4. For other targets, I don't know if a lower call site alignment would need to be respected. Ultimately we need an assert_align pseudo to track the call site attribute


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81297/new/

https://reviews.llvm.org/D81297





More information about the llvm-commits mailing list