[PATCH] D80274: [MachineVerifier] Handle the PHI node for verifyLiveVariables()

[Zhang Kang via Phabricator via llvm-commits]

ZhangKang marked 2 inline comments as done.
ZhangKang added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/livevars-crash2.mir:2
+# RUN: llc -mtriple powerpc64le-unknown-linux-gnu %s -o - 2>&1 \
+# RUN:   -run-pass=livevars,phi-node-elimination -verify-machineinstrs
 
----------------
aprantl wrote:
> A test that doesn't CHECK anything is almost entirely useless. It will succeed even if you symlink llc to /bin/true. Without a CHECK there is zero indication about what code path is supposed to be covered by it, so future maintainers will not know what aspect to preserve when updating the test. Please try to add a meaningful CHECK or delete the test.
Have added CHECK for the test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80274/new/

https://reviews.llvm.org/D80274