[PATCH] D79283: [PowerPC] Add missing handling for half precision

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 17 03:44:50 PDT 2020


stefanp added a comment.

LGTM.



================
Comment at: llvm/test/CodeGen/PowerPC/handle-f16-storage-type.ll:202
 declare i16 @llvm.convert.to.fp16.f32(float)
+define void @test_load_store(half* %in, half* %out) #0 {
+; P8-LABEL: test_load_store:
----------------
nemanjai wrote:
> stefanp wrote:
> > All of these functions are marked as `nounwind` (due to the `#0`) do they need to be marked as such?
> In general, when using the script to generate the checks, I prefer to use `nounwind` so that we don't get all the `cfi` directives that don't really contribute to the test - just add clutter.
Ok, makes sense. I should probably start doing this too in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79283/new/

https://reviews.llvm.org/D79283





More information about the llvm-commits mailing list