[PATCH] D81999: libclc: Fix rounding during type conversion

[Daniel Stone via Phabricator via llvm-commits]

daniels added a comment.

I don't have a good way to test this, but tbh I don't think anyone else does either, given it came from POCL so has been broken for as long as libclc's had any support for it. Looking into POCL just now, it looks like they applied the same fix <https://github.com/pocl/pocl/commit/fc9d276b266f5abe7a5d7715f8c6018a3865ed2f#diff-a3e10b0030c6b350f3a77976c0e72f9a> a few years ago. There are other fixes as well which might be good to take up, but I'm not going to propose any invasive changes, since SPIR-V doesn't (can't) use these helpers at all: the LLVM-SPIRV-Translator specifically looks for calls to the `convert_*` functions and replaces them with equivalently-decorated SPIR-V `OpConvert*`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81999/new/

https://reviews.llvm.org/D81999