[PATCH] D81997: [AArch64] SLSHardening: compute correct thunk name for X29.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SLSHardening.cpp:145
 
 static std::array<const char *, 29> SLSBLRThunkNames{
     "__llvm_slsblr_thunk_x0",  "__llvm_slsblr_thunk_x1",
----------------
I think it would be better to change these two arrays into one array of structs, so that the relationship between them is more obvious.


================
Comment at: llvm/lib/Target/AArch64/AArch64SLSHardening.cpp:179
+    if (Reg == SLSBLRThunkRegs[i]) {
+      Index = i;
+      break;
----------------
Could just `return SLSBLRThunkNames[i]` here.


================
Comment at: llvm/lib/Target/AArch64/AArch64SLSHardening.cpp:190
+    if (Name == SLSBLRThunkNames[i]) {
+      Index = i;
+      break;
----------------
Same as above,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81997/new/

https://reviews.llvm.org/D81997