[PATCH] D81230: Correctly report modified status for LoopIdiomRecognize

[serge via Phabricator via llvm-commits]

serge-sans-paille marked 2 inline comments as done.
serge-sans-paille added a comment.

Final comments addressed in the actual commit.



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1067
 
+  ExpandedValuesCleaner EVC{Expander, TLI};
+
----------------
foad wrote:
> How does this work? I thought brace initialization was only for structs with public fields (but I'm clearly not an expert). And even if it does work, wouldn't parentheses be a bit more "normal" than braces?
That's a list-initialization falling back to constructor call, as described in https://en.cppreference.com/w/cpp/language/list_initialization

grep for 
> Otherwise, the constructors of T are considered, in two phases: 

I've updated the code to use classic constructor, it's less ambiguous for the reader :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81230/new/

https://reviews.llvm.org/D81230