[PATCH] D81826: [DWARFYAML][debug_abbrev] Make the abbreviation code optional.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 17 01:34:54 PDT 2020
jhenderson added inline comments.
================
Comment at: llvm/include/llvm/ObjectYAML/DWARFYAML.h:55
struct Abbrev {
- llvm::yaml::Hex32 Code;
+ Optional<uint64_t> Code;
llvm::dwarf::Tag Tag;
----------------
I would suggest you keep this as a `Hex64` in this patch, and change it to a `uint64_t` in a separate patch, although I'm not entirely convinced either way whether it should be done at all. Perhaps @grimar has some thoughts?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81826/new/
https://reviews.llvm.org/D81826
More information about the llvm-commits
mailing list