[llvm] 9465dd5 - [Test] Add missing opportunity for replacement of select with Phi

[Max Kazantsev via llvm-commits]

Author: Max Kazantsev
Date: 2020-06-17T15:33:42+07:00
New Revision: 9465dd5ddd23e643e766a39da0cefa43b85db535

URL: https://github.com/llvm/llvm-project/commit/9465dd5ddd23e643e766a39da0cefa43b85db535
DIFF: https://github.com/llvm/llvm-project/commit/9465dd5ddd23e643e766a39da0cefa43b85db535.diff

LOG: [Test] Add missing opportunity for replacement of select with Phi

Added: 
    

Modified: 
    llvm/test/Transforms/InstCombine/select.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/InstCombine/select.ll b/llvm/test/Transforms/InstCombine/select.ll
index 5a0b0cae48d5..fde821286a4c 100644
--- a/llvm/test/Transforms/InstCombine/select.ll
+++ b/llvm/test/Transforms/InstCombine/select.ll
@@ -1669,3 +1669,62 @@ define float @copysign_wrong_const(float %x) {
   %r = select i1 %ispos, float 2.0, float -1.0
   ret float %r
 }
+
+; TODO: we can replace select with a Phi.
+define i32 @select_dominating_cond(i1 %cond, i32 %x, i32 %y) {
+; CHECK-LABEL: @select_dominating_cond(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    br i1 [[COND:%.*]], label [[IF_TRUE:%.*]], label [[IF_FALSE:%.*]]
+; CHECK:       if.true:
+; CHECK-NEXT:    br label [[MERGE:%.*]]
+; CHECK:       if.false:
+; CHECK-NEXT:    br label [[MERGE]]
+; CHECK:       merge:
+; CHECK-NEXT:    [[S:%.*]] = select i1 [[COND]], i32 [[X:%.*]], i32 [[Y:%.*]]
+; CHECK-NEXT:    ret i32 [[S]]
+;
+entry:
+  br i1 %cond, label %if.true, label %if.false
+
+if.true:
+  br label %merge
+
+if.false:
+  br label %merge
+
+merge:
+  %s = select i1 %cond, i32 %x, i32 %y
+  ret i32 %s
+}
+
+; TODO: We can replace select with a Phi and then sink a and b to respective
+; branches.
+define i32 @select_dominating_cond_and_sink(i1 %cond, i32 %x, i32 %y) {
+; CHECK-LABEL: @select_dominating_cond_and_sink(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    br i1 [[COND:%.*]], label [[IF_TRUE:%.*]], label [[IF_FALSE:%.*]]
+; CHECK:       if.true:
+; CHECK-NEXT:    br label [[MERGE:%.*]]
+; CHECK:       if.false:
+; CHECK-NEXT:    br label [[MERGE]]
+; CHECK:       merge:
+; CHECK-NEXT:    [[B:%.*]] = mul i32 [[X:%.*]], [[Y:%.*]]
+; CHECK-NEXT:    [[A:%.*]] = add i32 [[X]], [[Y]]
+; CHECK-NEXT:    [[S:%.*]] = select i1 [[COND]], i32 [[A]], i32 [[B]]
+; CHECK-NEXT:    ret i32 [[S]]
+;
+entry:
+  %a = add i32 %x, %y
+  %b = mul i32 %x, %y
+  br i1 %cond, label %if.true, label %if.false
+
+if.true:
+  br label %merge
+
+if.false:
+  br label %merge
+
+merge:
+  %s = select i1 %cond, i32 %a, i32 %b
+  ret i32 %s
+}