[PATCH] D81928: [llvm-readobj] - Split the printGnuHashTable(). NFCI.

Wed Jun 17 01:02:43 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2742
+
+  return GnuHashTable->values(NumSyms);
+}
----------------
Does the change to return an empty array in D81937 actually belong here? I'm a little confused why we seem to be introducing a function that is known to be broken from the outset, only to fix it immediately, rather than just doing it right straight up.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2782
+  if (!Chains) {
+    reportWarning(Chains.takeError(), ObjF->getFileName());
     return;
----------------
Does it make sense to change this to `reportUniqueWarning` whilst you're here?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81928/new/

https://reviews.llvm.org/D81928