[PATCH] D81527: [llvm-install-name-tool] Add `delete_rpath` option

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of small comments, but please wait for others to confirm they are happy with the latest test changes, as I don't know Mach-O well enough to follow the full logic.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/remove-lc-index-update.test:1
+## Check that removing load commands updates index for special LCs:
+
----------------
updates index for -> updates the indexes of


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/remove-lc-index-update.test:7-8
+
+# INDEX: Load command 3
+# INDEX-NEXT: cmd LC_DYLD_INFO_ONLY
+# INDEX: Load command 5
----------------
To make this easier to read, add additional spaces to make the checked patterns line up:
```
# INDEX:      Load command 3
# INDEX-NEXT: cmd LC_DYLD_INFO_ONLY
```

Same goes below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81527/new/

https://reviews.llvm.org/D81527