[PATCH] D80860: Exact integer emptiness checks for FlatAffineConstraints
Uday Bondhugula via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 17 00:30:18 PDT 2020
bondhugula added inline comments.
================
Comment at: mlir/unittests/Analysis/AffineStructuresTest.cpp:186
+ {
+ {3, -3, 1} // 3x - 3y + 1 = 0, i.e., y = x + 1/3.
+ }));
----------------
I'm sorry this would be caught by the GCD test itself. Instead, could you please replace the equality with something to the effect:
```
3x - 3y >= -2
3x - 3y <= -1
```
This should be empty as well but would exercise your method given how `isIntegerEmpty()` is structured now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80860/new/
https://reviews.llvm.org/D80860
More information about the llvm-commits
mailing list