[PATCH] D81943: [SROA] Teach SROA to perform no-op pointer conversion.

[Michael Liao via Phabricator via llvm-commits]

hliao marked an inline comment as done.
hliao added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:1780
+    unsigned NewAS = NewTy->getPointerAddressSpace();
+    // Generate pair of ptrtoint/inttoptr.
+    if (OldAS != NewAS) {
----------------
arsenm wrote:
> Isn't there a create-noop or create reinterpret cast somewhere?
> 
> This also probably needs more comments
so far, there is no cast creating that pair.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81943/new/

https://reviews.llvm.org/D81943