[PATCH] D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors.

[Zola Bridges via Phabricator via llvm-commits]

zbrid added a comment.

LGTM

Could you explain how not adding the MBB entry block is different from removing extra MBB later? Curious on the details about the differences here since the change makes sense functionally and I don't see any issues, but I can't understand why adding the extra MBB entry block at the point we create the machine function and then deleting extra blocks results in something different than the automatically created entry block. Is it some attributes or configuration in the basic block or something?

Also slightly unrelated question: Thanks for moving the IndirectThunk code to be of use to more Targets earlier in the commit stack! Along those lines, I was wondering if you had additional thoughts recently on adding retpolines for AArch64 since you are working near the x86 retpoline code and there was an llvm-dev thread from a team member of mine a week or two ago?



================
Comment at: llvm/include/llvm/CodeGen/IndirectThunks.h:67
 
   // MachineFunctions/MachineBasicBlocks aren't created automatically for the
   // IR-level constructs we already made. Create them and insert them into the
----------------
nit: update this comment to only mention MachineFunctions since MBBs don't need to be created.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81403/new/

https://reviews.llvm.org/D81403