[PATCH] D18683: Fix bug with duplicate struct types in Linker

Tim Armstrong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 16:29:04 PDT 2020


timarmstrong added a comment.

FWIW I ended up working around this for our specific use cases by automatically inserting a bunch of bitcasts - https://issues.apache.org/jira/browse/IMPALA-3877.

I spent a while trying to make some other stuff work and ended up coming to the conclusion that the Linker just isn't really designed or test for merging code into an arbitrary. It seemed to assume, at least when I was looking, that you started off with a pristine module then linked everything into that. That was a bit of a non-starter for our JIT use case, since we didn't want to add an extra linking step for our manually-generated IR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D18683/new/

https://reviews.llvm.org/D18683





More information about the llvm-commits mailing list