[PATCH] D81743: InlineCostAnnotationPrinterPass - Introducing the pass

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 15:23:52 PDT 2020


mtrofin accepted this revision.
mtrofin added a comment.
This revision is now accepted and ready to land.

lgtm

1 more nit - in the description "given one and them dumps the result": s/them/then



================
Comment at: llvm/lib/Analysis/InlineCost.cpp:2527
+  // In the current implementation, the type of InlineParams doesn't matter as
+  // the pass serves only
+  // We can add a flag which determines InlineParams for this run. Right now,
----------------
nit: the sentence doesn't finish


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81743/new/

https://reviews.llvm.org/D81743





More information about the llvm-commits mailing list