[PATCH] D81607: BreakCriticalEdges for callbr indirect dests

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 15:23:49 PDT 2020


efriedma added a comment.

LGTM, please merge.

I guess we can always revert this later in favor of another approach once we start seriously looking at complete blockaddress support.  This isn't making a huge commitment on its own

> (Going further, I'd be curious if having a blockaddress not scoped to a function is even generally useful?)

blockaddresses in global variables are required for compatibility with the gcc indirect goto extension.  (Really, we only need them in C static local variables, but that's the same thing in LLVM IR.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81607/new/

https://reviews.llvm.org/D81607





More information about the llvm-commits mailing list