[PATCH] D81894: [llvm-readobj][COFF] add .llvm.call-graph-profile section dump

[Zequan Wu via Phabricator via llvm-commits]

zequanwu marked an inline comment as done.
zequanwu added a comment.

In D81894#2094879 <https://reviews.llvm.org/D81894#2094879>, @jhenderson wrote:

> Thanks for splitting this up. The new test doesn't cover several of the error paths by the looks of it. You'll need to add additional test cases for each of these. I'd also expect a test case for no call graph section, to cover that code path, and possibly also for when there is more than one.


Those error paths in `printCGProfile` are about reading integers from `SectionData`, and only raise errors if the content of `SectionData` is not well formatted. I think it's probably not necessary. Since the `.llvm.call-graph-profile` section is written by `llvm-mc`. Shouldn't we assume the input is always valid? Otherwise, it's a problem of `llvm-mc`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81894/new/

https://reviews.llvm.org/D81894