[PATCH] D80177: [lld-macho] Set __PAGEZERO size to 4GB

[Vyacheslav Zakharin via Phabricator via llvm-commits]

vzakhari added a comment.

In D80177#2069811 <https://reviews.llvm.org/D80177#2069811>, @int3 wrote:

> Thanks for the heads up, just pushed a likely fix and will monitor http://lab.llvm.org:8011/builders/lld-x86_64-win. I'll set up a local Windows VM to catch future such issues earlier...


@int3, can you please point out the fix you pushed?  The tests are failing downstream, and I am looking for the commit that fixes it.

Moreover, in the head llvm-project there are still issues for 32-bit host builds:

  enum : uint64_t {
  ...
    PageZeroSize = 1ull << 32, // XXX should be 4096 for 32-bit targets
  ...
  };

`PageZeroSize` is a 64-bit constant, but it is being returned as `size_t`, which is 4 bytes for 32-bit hosts:

  class PageZeroSection : public SyntheticSection {
  ...
    size_t getSize() const override { return PageZeroSize; }
  ...

Could you please fix this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80177/new/

https://reviews.llvm.org/D80177