[PATCH] D81726: [MemDep] Also remove load instructions from NonLocalDesCache.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/MemoryDependenceAnalysis.cpp:1532
 
+  // Otherwise, if the instructions is in the map directly, it must be a load.
+  auto toRemoveIt = NonLocalDefsCache.find(RemInst);
----------------
efriedma wrote:
> The comment says "otherwise"; should this be an else-if?
Yes the otherwise refers to the preceding if. I move it into the else branch and also added a version of the test case that loads a pointer value. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81726/new/

https://reviews.llvm.org/D81726