[PATCH] D81829: [LangRef] Element-wise Integral Reduction Intrinsics

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.

LGTM as well.



================
Comment at: llvm/docs/LangRef.rst:12143-12144
+
+The '``llvm.abs``' intrinsic negates the argument, or each element of
+the argument if it is negative. If the argument is ``INT_MIN``, then the result
+is also ``INT_MIN`` if ``is_int_min_poison == 0`` and ``poison`` otherwise.
----------------
spatel wrote:
> First line is a bit awkward to me. How about:
> "Returns the magnitude (always positive) of the argument or each element of a vector argument."
The `(always positive)` note seems a bit odd here, given the INT_MIN behavior.


================
Comment at: llvm/docs/LangRef.rst:12125
+
+The '``llvm.abs``' family of intrinsic functions returns absolute value
+of an argument.
----------------
nit: "returns *the* absolute value"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81829/new/

https://reviews.llvm.org/D81829