[llvm] e4f19d1 - GlobalISel: Fix not failing on widening G_INSERT_VECTOR_ELT

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 12:49:20 PDT 2020


Author: Matt Arsenault
Date: 2020-06-16T15:48:57-04:00
New Revision: e4f19d1dda90e546737e0e7e9beada51fb74b27e

URL: https://github.com/llvm/llvm-project/commit/e4f19d1dda90e546737e0e7e9beada51fb74b27e
DIFF: https://github.com/llvm/llvm-project/commit/e4f19d1dda90e546737e0e7e9beada51fb74b27e.diff

LOG: GlobalISel: Fix not failing on widening G_INSERT_VECTOR_ELT

This doesn't actually handled type idx 0, but was reporting Legalized
on it. No test changes because nothing was trying to use this.

Added: 
    

Modified: 
    llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
index dfc4eba93568..643e7efe6500 100644
--- a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
@@ -2057,9 +2057,10 @@ LegalizerHelper::widenScalar(MachineInstr &MI, unsigned TypeIdx, LLT WideTy) {
       // TODO: Probably should be zext
       widenScalarSrc(MI, WideTy, 3, TargetOpcode::G_SEXT);
       Observer.changedInstr(MI);
+      return Legalized;
     }
 
-    return Legalized;
+    return UnableToLegalize;
   }
   case TargetOpcode::G_FADD:
   case TargetOpcode::G_FMUL:


        


More information about the llvm-commits mailing list