[PATCH] D81821: [AMDGPU] Make overlaps with ScratchRSrcReg fatal errors

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:339
   if (StackPtrReg) {
+    if (isSubRegister(ScratchRSrcReg, StackPtrReg))
+      report_fatal_error("scratch resource registers overlap stack pointer");
----------------
critson wrote:
> arsenm wrote:
> > This is only really an improvement for hand written MIR, and should go in the verifier?
> This can occur at compile time on LLVM IR with an -sgpr-limit set.
Do you mean the attributes to directly limit the number of SGPRs? These should not be used anymore, and this is one of the reasons why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81821/new/

https://reviews.llvm.org/D81821