[PATCH] D81716: Extend InlineFeatureAnalysis to more extract generic code features

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D81716#2096404 <https://reviews.llvm.org/D81716#2096404>, @jdoerfert wrote:

> In D81716#2096300 <https://reviews.llvm.org/D81716#2096300>, @mtrofin wrote:
>
> > In D81716#2096179 <https://reviews.llvm.org/D81716#2096179>, @jdoerfert wrote:
> >
> > > The printer pass needs a test. @mtrofin WDYT?
> >
> >
> > Yup - never hurts to add a test.
>
>
> My comment was formatted badly. The test is needed for sure, wanted to know if you are fine with the rename ;)


Ah, yes - lgtm

One overall nit: could we split this into the stand-alone rename, followed by the addition of the new code? Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81716/new/

https://reviews.llvm.org/D81716