[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

Tue Jun 16 12:39:54 PDT 2020

hliao added a comment.

In D81938#2095982 <https://reviews.llvm.org/D81938#2095982>, @tra wrote:

> In D81938#2095869 <https://reviews.llvm.org/D81938#2095869>, @hliao wrote:
>
> > In D81938#2095828 <https://reviews.llvm.org/D81938#2095828>, @lebedev.ri wrote:
> >
> > > This should be two separate patches - inferaddressspace and SROA.
> >
> >
> > Yes, I prepared that into 2 commits but `arc` combines them together.
>
>
> I usually put the patches into separate branches, with one having the other one as an upstream branch and then do arc diff with each branch checked out.
>  The downside is that you will need to rebase infer-branch every time you update sroa-branch.
>  Another approach that may work is to set arc config to only consider the checked out commit only. `arc set-config base "arc:this, arc:prompt"` should do that.

Thanks for the ar option approach. I usually do the same thing creating a bunch of local branches to separate individual changes. It's quite cumbersome to maintain them. More than 80 local branches are really difficult to maintain. Will try that arc option.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81938/new/

https://reviews.llvm.org/D81938