[PATCH] D81429: [COFF] Port CallGraphSort to COFF from ELF

[Zequan Wu via Phabricator via llvm-commits]

zequanwu added inline comments.


================
Comment at: lld/COFF/Driver.cpp:945
+    }
+
+    if (DefinedCOFF *dr = dyn_cast_or_null<DefinedCOFF>(sym))
----------------
hans wrote:
> ELF calls maybeWarnUnorderableSymbol() here, but I suppose there's no corresponding concept for COFF?
I don't find corresponding concept.


================
Comment at: lld/test/COFF/cgprofile-icf.s:2
+# REQUIRES: x86
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-win32 %s -o %t
----------------
hans wrote:
> Could you add a comment here that explains the intention of the test?
This is ported from ELF/cgprofile-icf.s. I suppose the intention is to test the compatibility of ICF and cgprofile


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81429/new/

https://reviews.llvm.org/D81429