[PATCH] D81527: [llvm-install-name-tool] Add `delete_rpath` option

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 11:32:56 PDT 2020


smeenai added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:832
+
+    // Cannot add & delete the same rpath at the same time.
+    if (is_contained(Config.RPathToAdd, RPath))
----------------
Super nit: spell out "and" instead of using "&"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81527/new/

https://reviews.llvm.org/D81527





More information about the llvm-commits mailing list