[PATCH] D81762: [CMake] Fix incorrect handling of get_target_property failure
Christopher Tetreault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 16 11:00:14 PDT 2020
ctetreau added a comment.
The following CMake invocation causes the issue for me:
cmake -G "Visual Studio 16 2019" -A x64 -Thost=x64 -DLLVM_TARGETS_TO_BUILD="all" -DLLVM_LIT_ARGS=-v -DLIBCLANG_BUILD_STATIC=ON -DLLVM_ENABLE_ASSERTIONS:BOOL=ON -DLLVM_ENABLE_PROJECTS='all' [llvm repo dir]/llvm
I'm using CMake 3.15.5. Even assuming that this is a behavior change in CMake (nothing in my research while debugging this issue indicates to me that this is the case), `"NOTFOUND"` and `"<varname>-NOTFOUND"` are both falsey, and I would assume we aren't naming test sites any of the magic CMake falsey values (`0`, `OFF`, `NO`, `FALSE`, `N`, `IGNORE`, `NOTFOUND`, the empty string, or ends in the suffix `-NOTFOUND`), so this should be fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81762/new/
https://reviews.llvm.org/D81762
More information about the llvm-commits
mailing list