[PATCH] D80991: [WIP][Attributor] AAPotentialValues Attribute

Tue Jun 16 11:00:14 PDT 2020

jdoerfert added a comment.

In D80991#2095399 <https://reviews.llvm.org/D80991#2095399>, @okura wrote:

> I found why it doesn't work. In 'AAValueSimplify::updateImpl' , sometimes 'askSimplifiedValueForAAPotentialValues' is not called and the dependency between them is not recorded. So I changed it to always call 'askSimplifiedValueForAAPotentialValues'.
>  I will add logic for binary operators  to 'AAPotentialValues::updateImpl'

So you'll update this shortly, right?

================
Comment at: llvm/test/Transforms/Attributor/potential.ll:1
+; Test for multiple potential values
+;
----------------
jdoerfert wrote:
> We need RUN lines and use the update test script to get check lines.
^ The different RUN lines are still missing. See the other tests :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80991/new/

https://reviews.llvm.org/D80991