[PATCH] D81940: [flang] AMAX0, MIN1... rewrite to MAX/MIN: make result conversion explicit

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 16 11:00:12 PDT 2020


schweitz accepted this revision.
schweitz added inline comments.


================
Comment at: flang/lib/Evaluate/fold-implementation.h:696
+    if (type.category() == resultType.category()) {
+      if (type.kind() > resultType.kind()) {
+        resultTypeArg = &args[j];
----------------
Is sign-extension always correct? Table 16.3 suggests AMAX0 has //default// integer arguments, which would possibly suggest truncation for something like INTEGER_16.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81940/new/

https://reviews.llvm.org/D81940





More information about the llvm-commits mailing list