[PATCH] D81495: [SVE] Remove invalid calls to VectorType::getNumElements from BasicTTIImpl

[Christopher Tetreault via Phabricator via llvm-commits]

ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:84
+  unsigned getBroadcastShuffleOverhead(VectorType *InVTy) {
+    auto *VTy = cast<FixedVectorType>(InVTy);
+
----------------
RKSimon wrote:
> We'd be better off just changing the function to take FixedVectorType, same for all the other cases below.
For the private methods, or all of them?

 I think changing the private methods to take FixedVectorType is fine. I prefer to leave the public methods as VectorType so that scalable architectures can use this interface.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81495/new/

https://reviews.llvm.org/D81495